Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: modify admin executors to support partitioned table with global index #20642

Closed
wants to merge 2 commits into from

Conversation

ldeng-ustc
Copy link
Contributor

What problem does this PR solve?

executor: support admin operators on partitioned table with global index.

What is changed and how it works?

Proposal: #18982

What's Changed and How it's Works:
buildCheckTable: Modify reader schema to support global index, use dynamic partition prune.
cleanupIndex: Build partitonHandle when index is global, modify table reader to read data in correct partition.
No change but write test cases for buildRecoverIndex, buildCheckIndexRange, buildCheckIndexRange.

Based on #20350.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note

  • N/A

@ldeng-ustc ldeng-ustc requested review from a team as code owners October 26, 2020 10:37
@ldeng-ustc ldeng-ustc requested review from lzmhhh123 and removed request for a team October 26, 2020 10:37
@github-actions github-actions bot added the sig/execution SIG execution label Oct 26, 2020
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jan 7, 2021
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed sig/infra labels Feb 22, 2021
@ti-chi-bot
Copy link
Member

@ldeng-ustc: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@winoros
Copy link
Member

winoros commented Jun 21, 2021

Sorry for the late response. Could you update this pr?
If you have any question, you can contact us via the slack channel.

@winoros winoros removed the request for review from a team June 21, 2021 09:11
@lzmhhh123 lzmhhh123 removed their request for review June 28, 2021 02:38
@Defined2014
Copy link
Contributor

Already covered by #53439 and #53019, close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/execution SIG execution sig/sql-infra SIG: SQL Infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants